From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7899 invoked by alias); 6 May 2011 17:42:07 -0000 Received: (qmail 7885 invoked by uid 22791); 6 May 2011 17:42:05 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 May 2011 17:41:47 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p46HfdlA028421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 May 2011 13:41:39 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p46HfcOU004480; Fri, 6 May 2011 13:41:38 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p46Hfbrl014962; Fri, 6 May 2011 13:41:38 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 6EFEA378303; Fri, 6 May 2011 11:41:37 -0600 (MDT) From: Tom Tromey To: Kwok Cheung Yeung Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Support for enabling/disabling tracepoints while a trace experiment is running References: <4DC2DDEF.10600@codesourcery.com> Date: Fri, 06 May 2011 17:42:00 -0000 In-Reply-To: <4DC2DDEF.10600@codesourcery.com> (Kwok Cheung Yeung's message of "Thu, 05 May 2011 18:27:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00198.txt.bz2 >>>>> ">" == Kwok Cheung Yeung writes: >> This patch adds support for enabling or disabling tracepoints while >> an experiment is running, by sending a new remote command to the >> gdbserver whenever this happens. Just one nit... >> Index: gdb/NEWS [...] >> Initial support for the OpenCL C language (http://www.khronos.org/opencl) >> has been integrated into GDB. >> +* Tracepoints can now be enabled and disabled at any time after a trace >> + experiment has been started using the standard "enable" and "disable" >> + commands. If a trace experiment is started with no enabled >> + tracepoints, then a warning will be printed but the experiment will >> + proceed anyway. I think these additions are in the "in 7.3" section but they should be in the "since 7.3" section. Tom