Re: [patch] [python] Expose some breakpoint operations to Python

Pedro Alves
2011-06-23T14:07:35Z

On Thursday 23 June 2011 13:35:02, Phil Muldoon wrote:
> This patch exposes to the Python API some breakpoint operations. The
> operations exported are:
>
> print_it
> print_one
> print_one_detail
> print_mention
>
> One of the changes made in this patch is to bind the Python breakpoint
> and the GDB breakpoint much earlier if the breakpoint is created from
> the Python API. This change was needed as some breakpoint operations
> are called before the observers are notified. Previously we bound the
> Python object and the breakpoint when the observer was notified. In the
> case where a breakpoint is not created from the Python API this is still
> the case. In any case, the ordering of breakpoint operations and
> breakpoint observers means we have to bind some breakpoints at
> creation. This has meant we have had to alter some of the breakpoint
> APIs to carry the breakpoint object in the parameter list at creation.
>
> I've included both MI and CLI tests. These are very similar. The MI
> tests are needed to prove that the exported Python APIs work
> seamlessly with MI notifications.
>
> Tested on X8664 Fedora 15 with no regressions.
>
> What do you think?

Well, here's my kneee jerk reaction. Last night I started converting
all breakpoints to use breakpoint_ops, and I immediately stumbled on
the fact that the print_one method doesn't appear to work as is. I
don't like the idea of exposing the API as is and getting stuck
with it when we haven't even made sure it's a good fit for
gdb's own regular breakpoints. :-(

--
Pedro Alves