From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10581 invoked by alias); 27 Jul 2011 16:22:41 -0000 Received: (qmail 10573 invoked by uid 22791); 27 Jul 2011 16:22:41 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Jul 2011 16:22:27 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6RGMRsW014624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Jul 2011 12:22:27 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6RGMQnu021724; Wed, 27 Jul 2011 12:22:27 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6RGMP19016716; Wed, 27 Jul 2011 12:22:26 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/2] Fix decode_locdesc for gcc-4.7.x optimized DWARF References: <20110727153041.GB9736@host1.jankratochvil.net> Date: Wed, 27 Jul 2011 16:58:00 -0000 In-Reply-To: <20110727153041.GB9736@host1.jankratochvil.net> (Jan Kratochvil's message of "Wed, 27 Jul 2011 17:30:41 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00766.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> There is decode_locdesc_read_mem workaround which is ugly, but it Jan> was already there in a different form. The same may be needed for Jan> DW_OP_GNU_push_tls_address but I haven't such a regression in the Jan> testsuite, DW_OP_GNU_push_tls_address is more for Jan> archer-jankratochvil-vla anyway. I think this patch is definitely an improvement. decode_locdesc was clearly a hack. Jan> The right fix would be dynamic types with DWARF blocks for various type Jan> fields. Yeah. Ouch. Jan> This change no longer supports bfd_get_sign_extend_vma / signed_addr_p for Jan> DW_OP_addr. But neither does dwarf2expr.c so I guess it is not a concern. I don't recall what happened here, but it doesn't matter -- if dwarf2expr.c is wrong, now at least we can fix it in a single place. Jan> + switch (ctx->location) Jan> + { Jan> + case DWARF_VALUE_REGISTER: Jan> + case DWARF_VALUE_MEMORY: Jan> + case DWARF_VALUE_STACK: I don't understand why DWARF_VALUE_REGISTER is ok here, or why DWARF_VALUE_LITERAL is not. Tom