From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84019-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29167 invoked by alias); 3 Oct 2011 16:32:12 -0000
Received: (qmail 29152 invoked by uid 22791); 3 Oct 2011 16:32:10 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Oct 2011 16:31:57 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p93GVrGe026475	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 3 Oct 2011 12:31:53 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p93GVqE4009928;	Mon, 3 Oct 2011 12:31:53 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p93GVpP2022030;	Mon, 3 Oct 2011 12:31:51 -0400
From: Tom Tromey <tromey@redhat.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, pmuldoon@redhat.com,        gdb-patches@sourceware.org
Subject: Re: [RFC - Python] New ObjFile event
References: <AANLkTimybJtpUzy13FuLxQQMJfeWQuf3-cgqGmu23Bq5@mail.gmail.com>	<AANLkTin=YO__Mz88HPFoT7a6_it5BxthnUdODJMs52eG@mail.gmail.com>	<m362r3q9ih.fsf@fleche.redhat.com>	<AANLkTikmMVf7Lz=8ccdXeo1WG8k+ivHMCXkC7BkZkLNP@mail.gmail.com>	<AANLkTi=ObZFW+uoecfzvHhXr55zYZzSgX2ocJJrvXDv0@mail.gmail.com>	<m339m4dgzr.fsf@redhat.com>	<AANLkTima2Kk8C16hjj0kTtvsH9W33CbiE2y6wrVQXns5@mail.gmail.com>	<m3ipt68mrs.fsf@fleche.redhat.com>	<BANLkTi=NqJK6c+Cbvhc1M2fE=cS=5khSJg@mail.gmail.com>	<CAPftXUKyge-BpB05PTn=5C=1HG6hgv8eS9rDYiZhooVMrrgZuQ@mail.gmail.com>	<E1Qz4Lp-0007E1-Kl@fencepost.gnu.org>	<CAPftXULTp2Z9PsY_RM+MAwahcEjNk2s=kgqUhz1guCMYUXGN9g@mail.gmail.com>
Date: Mon, 03 Oct 2011 16:32:00 -0000
In-Reply-To: <CAPftXULTp2Z9PsY_RM+MAwahcEjNk2s=kgqUhz1guCMYUXGN9g@mail.gmail.com>	(Kevin Pouget's message of "Thu, 1 Sep 2011 13:00:59 +0200")
Message-ID: <m3botyujd4.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00022.txt.bz2

>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:

Kevin> 	Allow Python notification of new object-file loadings.
[...]

Kevin> +During the callback, ``current objfile'' will be set to the new object file
Kevin> +(@pxref{Objfiles In Python}).

Why not simply make the objfile object an attribute of the event?
That seems cleaner to me.

Kevin> +  if (objfile == NULL)
Kevin> +       return;

Indentation looks off.

Tom