From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84775-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14176 invoked by alias); 28 Oct 2011 19:48:07 -0000
Received: (qmail 14166 invoked by uid 22791); 28 Oct 2011 19:48:06 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Oct 2011 19:47:45 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9SJlehX026375	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 28 Oct 2011 15:47:40 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9SJle4B008303;	Fri, 28 Oct 2011 15:47:40 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9SJlcZN027748;	Fri, 28 Oct 2011 15:47:38 -0400
From: Tom Tromey <tromey@redhat.com>
To: Justin Lebar <justin.lebar@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Stan Shebs <stan_shebs@mentor.com>,        gdb-patches@sourceware.org
Subject: Re: Status of 'blacklist' patch?
References: <CAD_=9DR9YN19cRJ4W7+oA+WQ92HCh=V08Ms8QL67V5cg4R12Kw@mail.gmail.com>	<CAFWcpZ7z8NjJ1T-cL2=JQO=5a+8e9t4r=_7aA1Nnds-gQZc74A@mail.gmail.com>	<4E8DCE67.80507@earthlink.net>	<CAFWcpZ56NugcRofZqrkK95Tjh5kcP+nuBpchZ1HWJ1HymaTgdg@mail.gmail.com>	<4E92E639.7000402@earthlink.net>	<CAFWcpZ6URBn2GNbLW0uUoZE6Pv+U8WoimmnmjHYtN8W_dt7rgA@mail.gmail.com>	<CADPb22RNLLeWaoU9sbOeUmdHS1zugnbiVu+pdTDdgwc+Wt0xgA@mail.gmail.com>	<CAFWcpZ7UuD23wChztKuxPuYCM8FdUfEOqzcHT85YHusoCOvRZw@mail.gmail.com>	<83ipnjs9i1.fsf@gnu.org>	<CAFWcpZ6JtXqu3W9A05CO5ZuAxYGev8W_-kUsGOZWDB5Y+2JuOA@mail.gmail.com>	<83ipndc92n.fsf@gnu.org>	<CAFWcpZ7Pjc+ey4K6oaganTGt5qr1m7HdJF9kM31x-THJcvr2Hw@mail.gmail.com>	<83ehy0ded8.fsf@gnu.org>	<CAFWcpZ4YRn4ZE+ZcXLtavpe=U4JdLnQUde91n5TdX51QpdrEGA@mail.gmail.com>	<4EA753C4.60408@mentor.com> <E1RIyYU-0004Vf-J8@fencepost.gnu.org>	<CAFWcpZ6L19SsFsJTD9Jf=Et7chWTeU-rywDmP6rDZzPPDnWFLw@mail.gmail.com>
Date: Fri, 28 Oct 2011 19:49:00 -0000
In-Reply-To: <CAFWcpZ6L19SsFsJTD9Jf=Et7chWTeU-rywDmP6rDZzPPDnWFLw@mail.gmail.com>	(Justin Lebar's message of "Wed, 26 Oct 2011 11:06:22 -0400")
Message-ID: <m3bot099ut.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00778.txt.bz2

>>>>> "Justin" == Justin Lebar <justin.lebar@gmail.com> writes:

One more note...

Justin> +int
Justin> +function_pc_is_marked_for_skip (CORE_ADDR pc)
Justin> +{
Justin> +  int searched_for_sal = 0;
Justin> +  struct symtab_and_line sal;
Justin> +  char *filename = NULL;
Justin> +  struct skiplist_entry *e;
Justin> +
Justin> +  sal = find_pc_line (pc, 0);
Justin> +  filename = sal.symtab->filename;

These last two lines should be removed.
They defeat the lazy computation scheme.

Justin> +	      sal = find_pc_line (pc, 0);
Justin> +	      filename = sal.symtab->filename;

I think sal.symtab can be NULL.

Tom