From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7320 invoked by alias); 22 Aug 2012 17:15:57 -0000 Received: (qmail 7311 invoked by uid 22791); 22 Aug 2012 17:15:56 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Aug 2012 17:15:44 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7MHFh9S001550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 22 Aug 2012 13:15:43 -0400 Received: from psique (ovpn-113-26.phx2.redhat.com [10.3.113.26]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7MHFe0H025258; Wed, 22 Aug 2012 13:15:41 -0400 From: Sergio Durigan Junior To: Siddhesh Poyarekar Cc: Michael Eager , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] bitpos: Expand type_field_bitpos to LONGEST and type.length to ULONGEST References: <20120805005359.2dc3edc0@spoyarek> <501E5C33.1020808@eagerm.com> <20120806083524.08b39f37@spoyarek> X-URL: http://www.redhat.com Date: Wed, 22 Aug 2012 17:15:00 -0000 In-Reply-To: <20120806083524.08b39f37@spoyarek> (Siddhesh Poyarekar's message of "Mon, 6 Aug 2012 08:35:24 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00621.txt.bz2 On Monday, August 06 2012, Siddhesh Poyarekar wrote: > On Sun, 05 Aug 2012 04:42:43 -0700, Michael wrote: >> The ChangeLog mentions a modification to microblaze-tdep.c, but the >> patch does not contain any changes to this file. >> > > Oh boy, I took the wrong diff from my repo when posting the patch -- I > had the patch in two changesets. Attached is the real patch for this. > ChangeLog added once again for review benefit. Hi Siddesh, Thanks for the patch. One issue I found: > diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c > index 0ea4df1..9479098 100644 > --- a/gdb/gdbtypes.c > +++ b/gdb/gdbtypes.c > @@ -953,7 +953,7 @@ create_array_type (struct type *result_type, > > struct type * > lookup_array_range_type (struct type *element_type, > - int low_bound, int high_bound) > + LONGEST low_bound, LONGEST high_bound) > { > struct gdbarch *gdbarch = get_type_arch (element_type); > struct type *index_type = builtin_type (gdbarch)->builtin_int; > @@ -989,7 +989,7 @@ create_string_type (struct type *result_type, > > struct type * > lookup_string_range_type (struct type *string_char_type, > - int low_bound, int high_bound) > + LONGEST low_bound, LONGEST high_bound) > { > struct type *result_type; These two functions' prototypes have to be updated on gdbtypes.h. Another issue I found, specifically on i386 RHEL 5.8 (gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-52)): (gdb) print e^M $1 = 4294967295^M (gdb) FAIL: gdb.base/enumval.exp: print e print f^M $2 = -1152921504606846976^M (gdb) FAIL: gdb.base/enumval.exp: print f print J^M $3 = J^M (gdb) PASS: gdb.base/enumval.exp: print J print K^M $4 = ^M (gdb) FAIL: gdb.base/enumval.exp: print K I still haven't debugged further to see what's happening, and I also haven't tested on a newer GCC (it can be a compiler bug, as you may remember from our last talk). I will come back if I have more info. Thanks, -- Sergio