Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] PR gdb/21226: Take DWARF stack value pieces from LSB end
Date: Mon, 13 Mar 2017 12:24:00 -0000	[thread overview]
Message-ID: <m3bmt5fjpu.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <fc2e4cf7-28f2-8855-8e59-835d8c1b2701@redhat.com> (Pedro Alves's	message of "Fri, 10 Mar 2017 19:29:18 +0000")

On Fri, Mar 10 2017, Pedro Alves wrote:

> On 03/08/2017 06:26 PM, Andreas Arnez wrote:
>
>> * pieces reaching outside the stack value bits are considered undefined,
>>   and a zero value can be used instead.
>
> I'm not exactly sure what that means, but doesn't "undefined" suggest
> "optimized out" instead?

For instance, consider a 20-byte piece from a stack value that is only 8
bytes wide.  AFAIK, this is invalid DWARF.

If we want to handle this case more gracefully, we could mark the upper
12 bytes optimzed out and still use the lower 8 bytes.  Or we could
treat it as an implementation-defined extension and perform zero- (or
sign-) extension to the full piece size.  But so far I didn't see it in
the scope of this bug fix to add such logic, particularly since it
doesn't exist for any other piece type either.

--
Andreas


      reply	other threads:[~2017-03-13 12:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 18:26 Andreas Arnez
2017-03-10 17:43 ` Ulrich Weigand
2017-03-10 19:24   ` Andreas Arnez
2017-03-10 17:57 ` Ulrich Weigand
2017-03-10 19:27   ` Andreas Arnez
2017-03-10 20:01     ` Ulrich Weigand
2017-03-13 12:18       ` Andreas Arnez
2017-03-10 19:29 ` Pedro Alves
2017-03-13 12:24   ` Andreas Arnez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3bmt5fjpu.fsf@oc1027705133.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox