From: Andreas Arnez <arnez@linux.ibm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [PATCH] s390: Fix infcalls passing a single-field struct with static members
Date: Tue, 15 Oct 2019 12:23:00 -0000 [thread overview]
Message-ID: <m3bluidwp0.fsf@oc0404454431.ibm.com> (raw)
In-Reply-To: <87wodb2n1h.fsf@tromey.com> (Tom Tromey's message of "Fri, 11 Oct 2019 11:46:02 -0600")
On Fri, Oct 11 2019, Tom Tromey wrote:
>>>>>> "Andreas" == Andreas Arnez <arnez@linux.ibm.com> writes:
>
> Andreas> The infcall-nested-structs test case yields 36 FAILs on s390x because GCC
> Andreas> and GDB disagree on how to pass a C++ struct like this as an argument to a
> Andreas> function:
>
> Andreas> struct s { float x; static float y; };
>
> Andreas> For the purpose of argument passing, GCC ignores static fields, while GDB
> Andreas> does not. Thus GCC passes the argument in a floating-point register and
> Andreas> GDB passes it via memory.
>
> Andreas> Fix this by explicitly ignoring static fields when detecting single-field
> Andreas> structs.
>
> FWIW this looked reasonable to me.
Thanks for having a look at this!
Pushed as ba18312d8f2cecf88b6edcbc277f433a62131e58.
--
Andreas
prev parent reply other threads:[~2019-10-15 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 14:50 Andreas Arnez
2019-10-11 17:46 ` Tom Tromey
2019-10-15 12:23 ` Andreas Arnez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bluidwp0.fsf@oc0404454431.ibm.com \
--to=arnez@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox