Re: [RFA] iRe: [RFC][patch 1/9] initial Python support

Daniel Jacobowitz
2008-07-21T02:03:51Z

On Sun, Jul 20, 2008 at 08:47:08PM -0300, Thiago Jung Bauermann wrote:
> Actually, I just found the problem. If Python support is not being
> compiled in, python/python.c will not be included in INIT_FILES. And the
> fact that python.o is in COMMON_OBS will not help because of the reason
> outlined in my comment. That's why I added python/python.c explicitly in
> INIT_FILES.
>
> Another way to solve the problem, which I am using this time, is to add
> the following else clause to configure.ac:

Is it in both COMMON_OBS and CONFIG_OBS? Sounds like it should be in
CONFIG_OBS all the time, never in COMMON_OBS. Which means CONFIG_OBS,
CONFIG_DEPS, CONFIG_SRCS also.

> if test "${have_libpython}" = yes; then
> AC_DEFINE(HAVE_PYTHON, 1, [Define if Python interpreter is being linked in.])
> CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_PYTHON_OBS)"
> CONFIG_DEPS="$CONFIG_DEPS \$(SUBDIR_PYTHON_DEPS)"
> CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_PYTHON_SRCS)"
> CONFIG_INITS="$CONFIG_INITS \$(SUBDIR_PYTHON_INITS)"
> ENABLE_CFLAGS="$ENABLE_CFLAGS \$(SUBDIR_PYTHON_CFLAGS)"

CONFIG_INITS appears to be obsolete.

--
Daniel Jacobowitz
CodeSourcery