Re: [patch] move the nottext flag to the instance_flags

Joel Brobecker
2010-10-01T16:15:38Z

> 2010-10-01 Ken Werner <ken.werner@de.ibm.com>
>
> * gdbtypes.h (struct main_type): Remove flag_nottext.
> (enum type_flag_value): Remove TYPE_FLAG_NOTTEXT.
> (enum type_instance_flag_value): Add TYPE_INSTANCE_FLAG_NOTTEXT.
> (TYPE_NOTTEXT): Use TYPE_INSTANCE_FLAG_NOTTEXT instead of flag_nottext.
> * gdbtypes.c (make_vector_type): Use TYPE_INSTANCE_FLAG_NOTTEXT instead
> of TYPE_FLAG_NOTTEXT.
> (init_type): Remove the initialization of the flag_nottext field.
> (gdbtypes_post_init): Use TYPE_INSTANCE_FLAG_NOTTEXT instead of
> TYPE_FLAG_NOTTEXT.
> * c-valprint.c (c_val_print): Remove TYPE_VECTOR check.
>
> testsuite/ChangeLog:
>
> 2010-10-01 Ken Werner <ken.werner@de.ibm.com>
>
> * gdb.base/gnu_vector.c: Add variable c4.
> * gdb.base/gnu_vector.exp: Add tests for character vector printing.
> * gdb.arch/altivec-abi.exp: Fix expect pattern of character vectors.

Looks good to me. Can you wait, maybe a day or two to give Tom a chance
to comment before you commit, in case he spots something I didn't?

Thanks,
--
Joel