From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32006 invoked by alias); 20 Sep 2008 04:55:02 -0000 Received: (qmail 31987 invoked by uid 22791); 20 Sep 2008 04:55:02 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 20 Sep 2008 04:54:27 +0000 Received: from int-mx01.intranet.prod.int.phx2.redhat.com (int-mx01.intranet.prod.int.phx2.redhat.com [10.5.30.51]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m8K4sNR1028943; Sat, 20 Sep 2008 00:54:24 -0400 Received: from opsy.redhat.com ([10.16.10.76]) by int-mx01.intranet.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id m8K4sNN3022444; Sat, 20 Sep 2008 00:54:23 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 07B7C3785D0; Fri, 19 Sep 2008 22:53:58 -0600 (MDT) To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: RFA: implement all missing macro expansion features References: <20080920001852.GC23372@adacore.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Sat, 20 Sep 2008 04:55:00 -0000 In-Reply-To: <20080920001852.GC23372@adacore.com> (Joel Brobecker's message of "Fri\, 19 Sep 2008 17\:18\:52 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00429.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> Thanks for adding the comment describing the function. Can you add an Joel> extra empty line before the function declaration? Sure. I was not sure which style is the preferred one -- though I see now that this is in gdbint.texinfo. That said, both styles are common in gdb, and in macroexp.c in particular, the blank line only appears in one case. Joel> Same here. And perhaps if you wouldn't mind describing the IS_VARARGS Joel> and VA_ARG_NAME parameters... Sure. >> + /* Just ignore a stray token splicing operator. Really this >> + is an error, but there's no reason to penalize the >> + user. */ Joel> I don't see how this would be penalizing the user. when could Joel> this error actually happen? Some versions of gcc will pass a macro like this through. Trunk rejects code that tries to do this. By 'this' I mean error cases like having '##' at the start or end of the macro definition. So, it can only happen in very weird circumstances. I can make it an error. I doubt anybody will notice. I'll resubmit the patch a bit later. Tom