Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFA: a small python-value.c normalization
Date: Mon, 22 Dec 2008 16:24:00 -0000	[thread overview]
Message-ID: <m3abao9o21.fsf@fleche.redhat.com> (raw)

This patch removes a #if from python-value.c.

We define Py_ssize_t as int in the cases where this is needed --
Python 2.4.  So, a second test is not needed.

FYI, there was a previous thread on this topic:

    http://sourceware.org/ml/archer/2008-q4/msg00111.html

Ok?

Tom

2008-12-22  Tom Tromey  <tromey@redhat.com>

	* python/python-value.c (valpy_length): Remove #if.

diff --git a/gdb/python/python-value.c b/gdb/python/python-value.c
index b23174c..9db7208 100644
--- a/gdb/python/python-value.c
+++ b/gdb/python/python-value.c
@@ -132,11 +132,7 @@ valpy_dereference (PyObject *self, PyObject *args)
   return value_to_value_object (res_val);
 }
 
-#ifdef HAVE_LIBPYTHON2_4
-static int
-#else
 static Py_ssize_t
-#endif
 valpy_length (PyObject *self)
 {
   /* We don't support getting the number of elements in a struct / class.  */


             reply	other threads:[~2008-12-22 16:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-22 16:24 Tom Tromey [this message]
2008-12-22 18:27 ` Pedro Alves
2008-12-22 19:48   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3abao9o21.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox