From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10168 invoked by alias); 23 Jun 2009 18:08:57 -0000 Received: (qmail 10159 invoked by uid 22791); 23 Jun 2009 18:08:56 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Jun 2009 18:08:47 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n5NI8j5v003309 for ; Tue, 23 Jun 2009 14:08:45 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5NI8jvD025632 for ; Tue, 23 Jun 2009 14:08:45 -0400 Received: from opsy.redhat.com (vpn-12-196.rdu.redhat.com [10.11.12.196]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5NI8jx4002891; Tue, 23 Jun 2009 14:08:45 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id E95023785DB; Tue, 23 Jun 2009 12:08:42 -0600 (MDT) To: Jan Kratochvil Cc: Paul Pluzhnikov , gdb-patches@sources.redhat.com Subject: Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.] References: <20090527001157.934BD76BC0@localhost> <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> <8ac60eac0906101839t4d3978fyc1c6d3b3e2eccb6e@mail.gmail.com> <8ac60eac0906101842y2d2fc9fco331cb4336d9508d0@mail.gmail.com> <8ac60eac0906161342m67c30151lc7f685e0eb36e41f@mail.gmail.com> <8ac60eac0906161407s6498913cu5e50e930d599be77@mail.gmail.com> <20090623150322.GA7654@host0.dyn.jankratochvil.net> From: Tom Tromey Reply-To: tromey@redhat.com Date: Tue, 23 Jun 2009 18:08:00 -0000 In-Reply-To: <20090623150322.GA7654@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue\, 23 Jun 2009 17\:03\:22 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00625.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> while sure your patch is great it has a regression. Assuming a regression Jan> reproducer needs to link GDB with -lmcheck (but did verify it). Thanks for finding this. Jan> 2009-06-23 Jan Kratochvil Jan> Fix a regression by the mmap patch from 2009-06-16. Jan> * symfile.c (reread_symbols): Move sym_finish and clear_objfile_data Jan> calls before deleting the OBJFILE obstack. Extend the comment. This is ok. Jan> + Try to keep the freeing order compatible with free_objfile. */ It seems like it would be nice to have a single function here. Tom