From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16327 invoked by alias); 12 Aug 2009 15:10:46 -0000 Received: (qmail 16218 invoked by uid 22791); 12 Aug 2009 15:10:44 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Aug 2009 15:10:32 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7CFAUcJ018294; Wed, 12 Aug 2009 11:10:30 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n7CFATQb013768; Wed, 12 Aug 2009 11:10:29 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7CFASSB019659; Wed, 12 Aug 2009 11:10:28 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B79D13782F1; Wed, 12 Aug 2009 09:10:27 -0600 (MDT) To: Michael Snyder Cc: Hui Zhu , "gdb-patches\@sourceware.org" Subject: Re: [RFA/RFC] Add dump and load command to process record (file format etc) References: <4A75054C.9030304@vmware.com> <83ws5koinl.fsf@gnu.org> <83my6fo2pa.fsf@gnu.org> <4A78935B.5030508@vmware.com> <4A79E90E.6090801@vmware.com> <4A82119A.3010405@vmware.com> From: Tom Tromey Reply-To: tromey@redhat.com Date: Wed, 12 Aug 2009 15:16:00 -0000 In-Reply-To: <4A82119A.3010405@vmware.com> (Michael Snyder's message of "Tue\, 11 Aug 2009 17\:49\:30 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00169.txt.bz2 >>>>> "Michael" == Michael Snyder writes: A few little nits in this patch. Most of these appear more than once. Michael> +extern bfd * Michael> +create_gcore_bfd (char *filename) Michael> { Don't use "extern" on definitions. Michael> +static bfd_vma Michael> +call_target_sbrk (int sbrk_arg) New functions should have an explanatory comment. Michael> +#include Michael> +#ifndef O_BINARY Michael> +#define O_BINARY 0 Michael> +#endif Michael> + Michael> +#include "regcache.h" Michael> +#include "regset.h" I think adding #includes in the middle of a file is ugly. Also, I think the O_BINARY define isn't needed -- it looks to me that defs.h does this. Tom