From: Tom Tromey <tromey@redhat.com>
To: Hilfinger@adacore.com
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [RFA] 64-bit range types in GDB
Date: Mon, 07 Dec 2009 20:08:00 -0000 [thread overview]
Message-ID: <m3aaxua6oy.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20091205121800.DB060227B32@nile.gnat.com> (Paul Hilfinger's message of "Sat, 5 Dec 2009 07:18:00 -0500 (EST)")
>>>>> "Paul" == Paul Hilfinger <Hilfinger@adacore.com> writes:
Paul> Hmm. Sticky. There's this comment on 'length' in struct type:
Paul> /* Length of storage for a value of this type. This is what
Paul> sizeof(type) would return; use it for address arithmetic,
Paul> memory reads and writes, etc. ....
Paul> But then the code goes on to define 'unsigned length'. However,
Paul> according to the C standard, the type should really be
Paul> size_t---and technically that should be the TARGET's size_t. I
Paul> suspect this part of the representation hasn't been updated since
Paul> the days when people actually used 16-bit address spaces. What do
Paul> you suppose people would say to using size_t here at least?
size_t won't help on 32-bit hosts. There is also ULONGEST.
struct type and struct main_type are size-critical. It would be nice
not to grow them.
I suppose it depends on how much we care about objects bigger than 4G.
An error would be cheaper :-)
I'm open to either approach, though.
Tom
next prev parent reply other threads:[~2009-12-07 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 8:13 Paul Hilfinger
2009-12-04 18:35 ` Tom Tromey
2009-12-05 12:18 ` Paul Hilfinger
2009-12-05 16:53 ` Pierre Muller
2009-12-07 20:08 ` Tom Tromey [this message]
2009-12-11 10:03 ` Paul Hilfinger
2009-12-11 19:06 ` Tom Tromey
2009-12-14 6:24 ` [COMMIT] " Paul Hilfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aaxua6oy.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=Hilfinger@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox