From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28059 invoked by alias); 8 Feb 2010 21:54:31 -0000 Received: (qmail 28051 invoked by uid 22791); 8 Feb 2010 21:54:31 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Feb 2010 21:54:26 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o18LsO4h026686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 8 Feb 2010 16:54:25 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o18LsOuh024751; Mon, 8 Feb 2010 16:54:24 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o18LsNZB004674; Mon, 8 Feb 2010 16:54:23 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 04AE837820A; Mon, 8 Feb 2010 14:54:22 -0700 (MST) From: Tom Tromey To: Chris Moller Cc: gdb-patches@sourceware.org Subject: Re: PR11067 patch References: <4B6D70A3.2090208@redhat.com> Reply-To: tromey@redhat.com Date: Mon, 08 Feb 2010 21:54:00 -0000 In-Reply-To: <4B6D70A3.2090208@redhat.com> (Chris Moller's message of "Sat, 06 Feb 2010 08:37:39 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00233.txt.bz2 >>>>> "Chris" == Chris Moller writes: Chris> The attached patch fixes bug 11067 "p should print the Chris> constant's value" by providing a means of setting a format string to Chris> be used in printing enums. The string is set with Chris> set enum-fmt I would rather not introduce a new option for this, particularly a formatting option. We don't have this sort of thing elsewhere in gdb -- we just pick a printing format or two. I re-read the thread on the archer list. I propose having it print like: $2 = ENUMERATOR = (enum tag) 23 However, i would suppress the extra stuff in structs and when printing in summary mode. Tom