Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/dwarf] Anonymous nested function causes SEGV during psymbol read
Date: Fri, 19 Feb 2010 03:06:00 -0000	[thread overview]
Message-ID: <m3aav5c4cc.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1266519724-4175-1-git-send-email-brobecker@adacore.com> (Joel 	Brobecker's message of "Thu, 18 Feb 2010 14:02:04 -0500")

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> +	  /* Ignore subprograms that do not have a name.  Such entries
Joel> +	     are incorrect, according to the DWARF standard, and we need
Joel> +	     a function name to create the associated partial symbol.  */
Joel> +	  if (!pdi->is_declaration && pdi->name)
Joel>              add_partial_symbol (pdi, cu);

I think it is worthwhile to call complaint for invalid DWARF.

Tom


  reply	other threads:[~2010-02-19  3:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18 19:02 Joel Brobecker
2010-02-19  3:06 ` Tom Tromey [this message]
2010-02-19 15:19   ` Joel Brobecker
2010-03-16 21:19   ` Joel Brobecker
2010-03-17 16:23     ` Joel Brobecker
2010-03-17 17:32       ` Tom Tromey
2010-03-18 18:39         ` Joel Brobecker
2010-03-18 19:00           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3aav5c4cc.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox