From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75257-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10315 invoked by alias); 30 Aug 2010 20:58:05 -0000
Received: (qmail 10306 invoked by uid 22791); 30 Aug 2010 20:58:05 -0000
X-SWARE-Spam-Status: No, hits=-6.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Aug 2010 20:57:59 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7UKvwoC031908	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 30 Aug 2010 16:57:58 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7UKvwso010241;	Mon, 30 Aug 2010 16:57:58 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7UKvv2T026098;	Mon, 30 Aug 2010 16:57:57 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 4FF3937822B; Mon, 30 Aug 2010 14:57:57 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/2] Use custom hash function with bcache [Re: [RFC] Use custom hash function with bcache]
References: <4C6946E1.6000709@redhat.com> <m339ucg6sj.fsf@fleche.redhat.com>	<4C6BF870.7010203@redhat.com> <m3lj84c5aa.fsf@fleche.redhat.com>	<4C6D5CC2.8060403@redhat.com> <m3aaoi2vix.fsf@fleche.redhat.com>	<4C7561B4.30101@redhat.com>
Date: Mon, 30 Aug 2010 20:58:00 -0000
In-Reply-To: <4C7561B4.30101@redhat.com> (sami wagiaalla's message of "Wed, 25	Aug 2010 14:32:20 -0400")
Message-ID: <m3aao3izsa.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-08/txt/msg00539.txt.bz2

>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> Revised patch attached.
Sami> Create and use a specialized bcache type for psymbols

Thanks for doing this.  A couple nits, nothing major.

Sami> +/* A bcache for partial symbols.  */
Sami> +
Sami> +struct psymbol_bcache
Sami> +{
Sami> +    struct bcache *bcache;

Too much indentation here.

Since psymbol_bcache is only used in psymtab.c, the definition should be
moved there, leaving just a forward declaration of the tag in psymtab.h.
This makes the type opaque, which is generally better.

Tom