From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5632 invoked by alias); 24 Nov 2010 18:25:31 -0000 Received: (qmail 5615 invoked by uid 22791); 24 Nov 2010 18:25:30 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Nov 2010 18:25:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAOIP3F1018708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Nov 2010 13:25:03 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAOIP2QP021470; Wed, 24 Nov 2010 13:25:02 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oAOIP1b2026958; Wed, 24 Nov 2010 13:25:02 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id AF219378885; Wed, 24 Nov 2010 11:25:01 -0700 (MST) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS) References: <1290474834-1945-1-git-send-email-brobecker@adacore.com> <201011231242.44422.pedro@codesourcery.com> <201011231628.33851.pedro@codesourcery.com> Date: Wed, 24 Nov 2010 18:25:00 -0000 In-Reply-To: <201011231628.33851.pedro@codesourcery.com> (Pedro Alves's message of "Tue, 23 Nov 2010 16:28:33 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00398.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Here's a patch. We can move the PyObject fallback typedef from defs.h Pedro> to varobj.c again. I haven't looked to see if the PyObject pointers Pedro> in struct varobj have some other concrete type we could forward Pedro> declare instead. Or why don't we #ifdef out those fields if building Pedro> without python. Pedro> Tested by building gdb with and without --with-python=no. Looks good to me. Tom