From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21603 invoked by alias); 5 Jan 2011 19:53:05 -0000 Received: (qmail 21481 invoked by uid 22791); 5 Jan 2011 19:53:04 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Jan 2011 19:52:54 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p05JqqC6010887 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Jan 2011 14:52:52 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p05JqqnU002966; Wed, 5 Jan 2011 14:52:52 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p05JqpU8019840; Wed, 5 Jan 2011 14:52:51 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 00F5937848D; Wed, 5 Jan 2011 12:52:50 -0700 (MST) From: Tom Tromey To: gdb-patches@sourceware.org Subject: RFA: document frame types, plus add missing ones Date: Wed, 05 Jan 2011 19:53:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00083.txt.bz2 This patch fixes PR python/12133. The bug is that the return values for Frame.type are not documented. While doing this, I noticed that we didn't expose all the frame types. So, this patch adds the missing ones as well. Doc review needed. Ok? Tom 2011-01-05 Tom Tromey * python/py-frame.c (gdbpy_initialize_frames): Add INLINE_FRAME and ARCH_FRAME. 2011-01-05 Tom Tromey PR python/12133: * gdb.texinfo (Frames In Python): Document various frame constants. Index: doc/gdb.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.783 diff -u -r1.783 gdb.texinfo --- doc/gdb.texinfo 5 Jan 2011 05:09:52 -0000 1.783 +++ doc/gdb.texinfo 5 Jan 2011 19:51:12 -0000 @@ -22536,9 +22536,29 @@ @end defmethod @defmethod Frame type -Returns the type of the frame. The value can be one of -@code{gdb.NORMAL_FRAME}, @code{gdb.DUMMY_FRAME}, @code{gdb.SIGTRAMP_FRAME} -or @code{gdb.SENTINEL_FRAME}. +Returns the type of the frame. The value can be one of: +@table @code +@item gdb.NORMAL_FRAME +An ordinary stack frame. + +@item gdb.DUMMY_FRAME +A fake stack frame that was created by @value{GDBN} when performing an +inferior function call. + +@item gdb.INLINE_FRAME +A frame representing an inlined function. The function was inlined +into a @code{gdb.NORMAL_FRAME} that is newer than this one. + +@item gdb.SIGTRAMP_FRAME +A frame in a signal handler. + +@item gdb.ARCH_FRAME +A fake stack frame representing a cross-architecture call. + +@item gdb.SENTINEL_FRAME +This is like @code{gdb.NORMAL_FRAME}, but it is only used for the +newest frame. +@end table @end defmethod @defmethod Frame unwind_stop_reason Index: python/py-frame.c =================================================================== RCS file: /cvs/src/src/gdb/python/py-frame.c,v retrieving revision 1.10 diff -u -r1.10 py-frame.c --- python/py-frame.c 1 Jan 2011 15:33:25 -0000 1.10 +++ python/py-frame.c 5 Jan 2011 19:51:13 -0000 @@ -574,7 +574,9 @@ That seems too messy. */ PyModule_AddIntConstant (gdb_module, "NORMAL_FRAME", NORMAL_FRAME); PyModule_AddIntConstant (gdb_module, "DUMMY_FRAME", DUMMY_FRAME); + PyModule_AddIntConstant (gdb_module, "INLINE_FRAME", INLINE_FRAME); PyModule_AddIntConstant (gdb_module, "SIGTRAMP_FRAME", SIGTRAMP_FRAME); + PyModule_AddIntConstant (gdb_module, "ARCH_FRAME", ARCH_FRAME); PyModule_AddIntConstant (gdb_module, "SENTINEL_FRAME", SENTINEL_FRAME); PyModule_AddIntConstant (gdb_module, "FRAME_UNWIND_NO_REASON", UNWIND_NO_REASON);