From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21098 invoked by alias); 24 Feb 2011 18:58:22 -0000 Received: (qmail 21089 invoked by uid 22791); 24 Feb 2011 18:58:22 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Feb 2011 18:58:14 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1OIvoiZ004368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 Feb 2011 13:57:50 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1OIvods023793; Thu, 24 Feb 2011 13:57:50 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1OIvnoh019838; Thu, 24 Feb 2011 13:57:49 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 6236C378388; Thu, 24 Feb 2011 11:57:49 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 02/18] New command_post observer References: <1298569763-18784-1-git-send-email-brobecker@adacore.com> <1298569763-18784-3-git-send-email-brobecker@adacore.com> Date: Thu, 24 Feb 2011 18:58:00 -0000 In-Reply-To: <1298569763-18784-3-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 24 Feb 2011 12:49:07 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00721.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> What we are trying to do is to keep the user informed of the current Joel> PD (which is identified by either PD ID or name, but we like to print Joel> both). I have a patch kicking around here to add prompt substitutions to gdb. This might be a nice fit for this use. I can try to submit this soon if you think it is worthwhile. I wasn't really sure. Joel> This patch introduces an observer (command_post) that gets triggered Joel> at the end of a command execution... I think an observer for this is fine... Joel> (execute_command): Call observer_notify_command_post. ... but putting it here seems a little strange. I think this will trigger after any command that is executed, including commands in "command" or in a "define" or via Python's gdb.execute. I would have thought that a "top-level" notification would have been more along the lines of what you wanted. Tom