From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80345-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7503 invoked by alias); 15 Apr 2011 18:22:13 -0000
Received: (qmail 7490 invoked by uid 22791); 15 Apr 2011 18:22:12 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Apr 2011 18:21:46 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3FILedR013248	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 15 Apr 2011 14:21:40 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3FILduG007452;	Fri, 15 Apr 2011 14:21:39 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3FILcWx005631;	Fri, 15 Apr 2011 14:21:39 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 83622379306; Fri, 15 Apr 2011 12:21:38 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>, "'Maxim Grigoriev'" <maxim@tensilica.com>
Subject: Re: [RFA-v2] xtensa-tdep.c ARI fixes
References: <15837.6740910628$1302342165@news.gmane.org>	<m34o60fuc2.fsf@fleche.redhat.com>	<37948.3434990563$1302853234@news.gmane.org>
Date: Fri, 15 Apr 2011 18:22:00 -0000
In-Reply-To: <37948.3434990563$1302853234@news.gmane.org> (Pierre Muller's	message of "Fri, 15 Apr 2011 09:40:05 +0200")
Message-ID: <m3aafrcr4d.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00227.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   Here is a new version that adds this xfree call.
Pierre> Could someone test this patch out?
Pierre> Again, I have no way to trigger that code, so I can't really test it.

The patch looks good to me.
But I agree, testing would be nice.

Pierre> +	   &&  (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA);

Extra space after the "&&" :-)

Tom