From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16285 invoked by alias); 23 May 2011 15:35:17 -0000 Received: (qmail 16205 invoked by uid 22791); 23 May 2011 15:35:16 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 15:35:00 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4NFYcS8017913 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 23 May 2011 11:34:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4NFYb55003671; Mon, 23 May 2011 11:34:37 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4NFYaMx003250; Mon, 23 May 2011 11:34:37 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 9DBF83791A0; Mon, 23 May 2011 09:34:36 -0600 (MDT) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] aix: add support for dwarf2. References: <1306146544-3925-1-git-send-email-gingold@adacore.com> <1306146544-3925-4-git-send-email-gingold@adacore.com> Date: Mon, 23 May 2011 15:35:00 -0000 In-Reply-To: <1306146544-3925-4-git-send-email-gingold@adacore.com> (Tristan Gingold's message of "Mon, 23 May 2011 12:29:03 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00530.txt.bz2 >>>>> "Tristan" == Tristan Gingold writes: Tristan> +static const struct dwarf2_debug_sections dwarf2_xcoff_names = { Tristan> + { ".dwinfo", NULL }, Tristan> + { ".dwabrev", NULL }, Tristan> + { ".dwline", NULL }, Tristan> + { ".dwloc", NULL }, Tristan> + { NULL, NULL }, /* debug_macinfo */ Tristan> + { ".dwstr", NULL }, Tristan> + { ".dwrnges", NULL }, Tristan> + { NULL, NULL }, /* debug_types */ Tristan> + { ".dwframe", NULL }, Tristan> + { NULL, NULL }, /* eh_frame */ Tristan> + { NULL, NULL } /* gdb_index */ Tristan> +}; I don't like this approach, because it requires some non-obvious code synchronization between this struct and dwarf2read. I think some kind of name mapping approach would be preferable -- that way, we would be free to change dwarf2read without needing to update structs in other parts of gdb. If you don't want to do this in BFD, I think it would be fine to do it locally in gdb. What do you think? Tom