From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82068-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8648 invoked by alias); 5 Jul 2011 18:34:13 -0000
Received: (qmail 8283 invoked by uid 22791); 5 Jul 2011 18:34:13 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jul 2011 18:33:54 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p65IXqNk022976	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 5 Jul 2011 14:33:52 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p65IXqZ7016943;	Tue, 5 Jul 2011 14:33:52 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p65IXoXH013654;	Tue, 5 Jul 2011 14:33:51 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA/tracepoint] Make GDB can work with some old GDB server
References: <BANLkTimuz12OVGoF9tKoV2ikcj9LKFax_g@mail.gmail.com>
Date: Tue, 05 Jul 2011 18:35:00 -0000
In-Reply-To: <BANLkTimuz12OVGoF9tKoV2ikcj9LKFax_g@mail.gmail.com> (Hui Zhu's	message of "Fri, 24 Jun 2011 16:46:58 +0800")
Message-ID: <m3aacstw4x.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00163.txt.bz2

>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:

>> 2011-06-24  Hui Zhu  <teawater@gmail.com>
>> 	* remote.c (remote_start_remote): Add TRY_CATCH for
>> 	remote_get_trace_status.
>> 	* tracepoint.c (disconnect_tracing): Ditto.

It seems reasonable enough to me, but I would prefer that somebody more
knowledgeable about remote.c review this.

>> +      warning(_("%s"), ex.message);

Space before the first open paren.

>> +      warning(_("%s"), ex.message);

Likewise.

Tom