From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6234 invoked by alias); 26 Aug 2011 20:23:56 -0000 Received: (qmail 6221 invoked by uid 22791); 26 Aug 2011 20:23:55 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 20:23:37 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7QKNa00004423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Aug 2011 16:23:36 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7QKNZ7v006178; Fri, 26 Aug 2011 16:23:36 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7QKNYB2005144; Fri, 26 Aug 2011 16:23:34 -0400 From: Tom Tromey To: matt rice Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/7] [python] API for macros: abort or continuing macro iterators. References: <1314198654-9008-1-git-send-email-ratmice@gmail.com> <1314198654-9008-2-git-send-email-ratmice@gmail.com> Date: Fri, 26 Aug 2011 20:23:00 -0000 In-Reply-To: <1314198654-9008-2-git-send-email-ratmice@gmail.com> (matt rice's message of "Wed, 24 Aug 2011 08:10:48 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00510.txt.bz2 >>>>> "matt" == matt rice writes: matt> 2011-08-23 Matt Rice matt> * macrocmd.c (print_macro_callback): Return a walk status matt> and continue indefinitely. matt> (print_one_macro): Ditto. matt> * macrotab.c (foreach_macro): Return based on callback matt> status. matt> (foreach_macro_in_scope): Ditto. matt> (macro_for_each): Return a macro walk completion result. matt> (macro_for_each_in_scope): Ditto. matt> * macrotab.h (macro_walk_status): New enum. matt> (macro_walk_result): Ditto. matt> (macro_callback_fn): Return a macro_walk_status. matt> (macro_for_each, macro_for_each_in_scope): Return a macro_walk_result. matt> * symtab.c (add_macro_name): Return a walk status and matt> continue indefinitely. This one is ok, but please do not commit it until the whole series is ready. In the future it would help if each patch had a description that was a bit longer than just the Subject: line. Tom