From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19721 invoked by alias); 2 Nov 2011 19:47:23 -0000 Received: (qmail 19704 invoked by uid 22791); 2 Nov 2011 19:47:20 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 19:47:03 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA2Jkvef025357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Nov 2011 15:46:57 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA2JkvEw011427; Wed, 2 Nov 2011 15:46:57 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA2Jks33009553; Wed, 2 Nov 2011 15:46:55 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Ulrich Weigand Subject: Re: RFC: don't set the pspace on ordinary breakpoints References: <201111021854.42981.pedro@codesourcery.com> Date: Wed, 02 Nov 2011 19:47:00 -0000 In-Reply-To: <201111021854.42981.pedro@codesourcery.com> (Pedro Alves's message of "Wed, 2 Nov 2011 18:54:42 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00052.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Could have been two independent patches. Ok, noted. Tom> First, it changes ordinary breakpoints to set leave their 'pspace' field Tom> NULL. The rationale for this is that, with the ambiguous linespec Tom> patch, a linespec may apply to different program spaces, not just the Tom> one which was selected when the breakpoint was created. For these Tom> breakpoints, we do not want breakpoint_program_space_exit to remove the Tom> breakpoint. Pedro> I'm not clear how this isn't breaking multi-process without Pedro> the linespec changes. I mean, if we no longer have a pspace Pedro> pointer, breakpoint re-setting will no longer work correctly. Pedro> (breakpoint_re_set -> ... -> prepare_re_set_context) Yeah, it probably does. I'm not sure why this doesn't result in any regressions. I won't put it in separately... it is mostly useful as a way to break off a chunk of the huge linespec patch for readability. Pedro> I don't think that's correct. During startup, we disable user Pedro> breakpoints, because the symbols haven't been relocated yet. Pedro> But, we still need to insert internal breakpoints set at magic Pedro> addresses (not through symbols), so that we know when the startup Pedro> is done with. Ulrich? Ok. How would I test this? Plan B would be to put the startup-disabled state on bp_location. Tom