From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85118-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12828 invoked by alias); 10 Nov 2011 19:27:28 -0000
Received: (qmail 12819 invoked by uid 22791); 10 Nov 2011 19:27:27 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Nov 2011 19:27:13 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAAJR7VV024930	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 10 Nov 2011 14:27:07 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pAAJR7eg026978;	Thu, 10 Nov 2011 14:27:07 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pAAJR4ZF006767;	Thu, 10 Nov 2011 14:27:05 -0500
From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: pedro@codesourcery.com (Pedro Alves), gdb-patches@sourceware.org
Subject: Re: RFC: don't set the pspace on ordinary breakpoints
References: <m3d3czdind.fsf@fleche.redhat.com>	<201111101757.pAAHvaCl032698@d06av02.portsmouth.uk.ibm.com>
Date: Thu, 10 Nov 2011 19:27:00 -0000
In-Reply-To: <201111101757.pAAHvaCl032698@d06av02.portsmouth.uk.ibm.com>	(Ulrich Weigand's message of "Thu, 10 Nov 2011 18:57:36 +0100 (CET)")
Message-ID: <m3aa83bwxj.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00295.txt.bz2

>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:

Ulrich> Or maybe rather, since the sole remaining function of that loop
Ulrich> is to sometimes skip the update_global_location_list, which doesn't
Ulrich> appear to have any reason except performance tuning (which is
Ulrich> really unnecessary here as this routine is called extremely rarely)
Ulrich> -- why not just remove the whole loop and just call
Ulrich> update_global_location_list unconditionally?

Sounds good to me.  I removed the loop and will retest shortly.

Tom