From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85369-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18403 invoked by alias); 21 Nov 2011 19:59:54 -0000
Received: (qmail 18388 invoked by uid 22791); 21 Nov 2011 19:59:53 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Nov 2011 19:59:34 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pALJxWGL021836	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 21 Nov 2011 14:59:32 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pALJxW58028706;	Mon, 21 Nov 2011 14:59:32 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pALJxUD6020247;	Mon, 21 Nov 2011 14:59:31 -0500
From: Tom Tromey <tromey@redhat.com>
To: <Paul_Koning@Dell.com>
Cc: <pmuldoon@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [python] [patch] PR 13369/13374
References: <m3ipmdem7n.fsf@redhat.com>	<09787EF419216C41A903FD14EE5506DD030EBD9671@AUSX7MCPC103.AMER.DELL.COM>
Date: Mon, 21 Nov 2011 19:59:00 -0000
In-Reply-To: <09787EF419216C41A903FD14EE5506DD030EBD9671@AUSX7MCPC103.AMER.DELL.COM>	(Paul Koning's message of "Mon, 21 Nov 2011 05:50:06 -0600")
Message-ID: <m3aa7p9rh9.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00546.txt.bz2

>>>>> "Paul" ==   <Paul_Koning@Dell.com> writes:

>> +      /* Note -- this is not thread-safe.  */

Paul> Does the comment "not thread safe" indicate that this is a spot where
Paul> the GIL should be acquired and isn't currently?  Or doesn't the GIL
Paul> help for that?

The comment refers to the code being called here.
I think the comment can be removed.  It isn't ok to call gdb stuff from
other Python threads anyway.

Tom