From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3539 invoked by alias); 18 Jan 2012 05:17:19 -0000 Received: (qmail 3528 invoked by uid 22791); 18 Jan 2012 05:17:17 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jan 2012 05:17:00 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0I5Gxmk014429 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Jan 2012 00:16:59 -0500 Received: from psique ([10.3.112.12]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0I5GtIL028019; Wed, 18 Jan 2012 00:16:57 -0500 From: Sergio Durigan Junior To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC 2/8] C language References: X-URL: http://www.redhat.com Date: Wed, 18 Jan 2012 11:38:00 -0000 In-Reply-To: (Tom Tromey's message of "Mon, 16 Jan 2012 11:03:14 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00663.txt.bz2 On Monday, January 16 2012, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior writes: > > Sergio> Here and in all the .y files, I had to add an argument to the parser and > Sergio> the lexer functions, which is a `struct parser_state *ps'. > > I think 'ps' is too short a name for something used all over the file. Sorry, I am not sure you saw my other message. I was questioning if `pstate' is a better name in your opinion. Since the find-and-replace takes lots of time, I decided to ask instead of sending another round of patches... Thanks. -- Sergio