From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFC: extend symtabs_from_filename skipping for C++
Date: Wed, 08 Feb 2012 20:10:00 -0000 [thread overview]
Message-ID: <m3aa4taxyg.fsf@fleche.redhat.com> (raw)
I'd appreciate comments on this. Barring comments I will check it in
after a couple days.
A while ago Doug committed a patch to change linespec to skip
symtabs_from_filename when possible. This was an important performance
improvement.
We got a bug report in Red Hat bugzilla asking that this be extended to
C++ qualified names:
https://bugzilla.redhat.com/show_bug.cgi?id=787487
This patch implements this idea.
Built and regtested on x86-64 Fedora 15.
Tom
2012-02-08 Tom Tromey <tromey@redhat.com>
* linespec.c (decode_line_internal): Skip symtabs_from_filename
when we have a C++ qualified name.
diff --git a/gdb/linespec.c b/gdb/linespec.c
index da88d17..3f53b8e 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -912,9 +912,11 @@ decode_line_internal (struct linespec_state *self, char **argptr)
/* First things first: if ARGPTR starts with a filename, get its
symtab and strip the filename from ARGPTR.
Avoid calling symtab_from_filename if we know can,
- it can be expensive. */
+ it can be expensive. We know we can avoid the call if we see a
+ single word (e.g., "break NAME") or if we see a qualified C++
+ name ("break QUAL::NAME"). */
- if (*p != '\0')
+ if (*p != '\0' && p[1] != ':')
{
TRY_CATCH (file_exception, RETURN_MASK_ERROR)
{
next reply other threads:[~2012-02-08 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 20:10 Tom Tromey [this message]
2012-02-08 22:06 ` Joel Brobecker
2012-02-10 13:34 ` Jan Kratochvil
2012-02-10 17:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aa4taxyg.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox