From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-39360-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 18103 invoked by alias); 12 May 2005 02:18:18 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 17500 invoked from network); 12 May 2005 02:17:55 -0000
Received: from unknown (205.217.158.180)
  by sourceware.org with QMTP; 12 May 2005 02:17:55 -0000
Received: (qmail 27727 invoked by uid 10); 12 May 2005 02:17:54 -0000
Received: (qmail 10287 invoked by uid 500); 12 May 2005 02:17:43 -0000
To: Eli Zaretskii <eliz@gnu.org>
Cc: djgpp-workers@delorie.com, gcc-patches@gcc.gnu.org,
  gdb-patches@sourceware.org
Subject: Re: RFA: fix libiberty/pex-djgpp.c
References: <01c5565c$Blat.v2.4$082130a0@zahav.net.il>
	<m3y8alqzgx.fsf@gossamer.airs.com>
	<01c55680$Blat.v2.4$9ebe4740@zahav.net.il>
From: Ian Lance Taylor <ian@airs.com>
Date: Thu, 12 May 2005 03:46:00 -0000
In-Reply-To: <01c55680$Blat.v2.4$9ebe4740@zahav.net.il>
Message-ID: <m38y2lqjaw.fsf@gossamer.airs.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2005-05/txt/msg00263.txt.bz2

"Eli Zaretskii" <eliz@gnu.org> writes:

> > Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org,
> >    djgpp-workers@delorie.com
> > From: Ian Lance Taylor <ian@airs.com>
> > Date: 11 May 2005 16:28:30 -0400
> > 
> > You don't need pex_djgpp_fdopenr.  It will only be called if
> > pex_init_common is called with PEX_USE_PIPES
> 
> It's not easy to figure out what is needed and in what conditions.  It
> would be nice if this machinery were to be documented a bit more
> methodically.  Right now, the information is scattered between
> pex-common.h, include/libiberty.h and a few comments in pex-*.c files.

Don't forget pexecute.txh.

It's true that I did not bother to fully document the internals.  I
don't anticipate that very many people will be writing new pex-*.c
files.

> > Otherwise, this patch is approved.  Please check it into the gcc
> > repository first, as usual with libiberty patches.
> 
> I don't think I have write access to the GCC repository, sorry.

I will check it in soon, then.  Thanks.

Ian