From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10376 invoked by alias); 14 Aug 2007 16:53:03 -0000 Received: (qmail 10366 invoked by uid 22791); 14 Aug 2007 16:53:02 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 14 Aug 2007 16:52:56 +0000 Received: (qmail 11340 invoked from network); 14 Aug 2007 16:52:54 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Aug 2007 16:52:54 -0000 To: msnyder@sonic.net Cc: gdb-patches@sourceware.org Subject: Re: [patch] jv-lang.c, dead code References: <21135.12.7.175.2.1186286956.squirrel@webmail.sonic.net> <17486.12.7.175.2.1187046807.squirrel@webmail.sonic.net> From: Jim Blandy Date: Tue, 14 Aug 2007 16:53:00 -0000 In-Reply-To: <17486.12.7.175.2.1187046807.squirrel@webmail.sonic.net> (msnyder@sonic.net's message of "Mon, 13 Aug 2007 16:13:27 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00288.txt.bz2 msnyder@sonic.net writes: >> msnyder@sonic.net writes: >>> noside is tested twice. >> >> I'd agree that the code is messed up, and that your patch doesn't >> change its behavior, but which test is the one that ought to be there? >> I don't even know when EVAL_SKIP would be used for Java. > > Any thoughts on what we ought to do about this? I vote leave it alone.