Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] Pre-parse XML target descriptions
Date: Fri, 05 Oct 2007 17:52:00 -0000	[thread overview]
Message-ID: <m38x6hzbx4.fsf@codesourcery.com> (raw)
In-Reply-To: <20071005174009.GA3182@caradoc.them.org> (Daniel Jacobowitz's message of "Fri, 5 Oct 2007 13:40:09 -0400")


Daniel Jacobowitz <drow at false.org> writes:
> On Fri, Oct 05, 2007 at 09:54:21AM -0700, Jim Blandy wrote:
>> Actually, the mechanism I suggested could be incorporated in any
>> case.  The GDB build process should always check the checksums of the
>> XML input files against those stored in the files built from them,
>> simply to remind developers when they need to regenerate the C files.
>> It's just a good general principle for dealing with pre-generated
>> files.
>
> But honestly, is it worth the trouble?  If we do that we have to
> content with at least these issues:
>
>   - $build != $host; can not run GDB at all
>   - Expat not available; can not parse descriptions
>   - GDB needs the descriptions to build but can't regenerate them
>     until after it is built.
>
> I don't think it's important enough to make the build system
> more complicated.

I think you're imagining something more complicated than I had in
mind.  This is all I meant:

gdb: check-xml-regs

check-xml-regs: foo.check-xml-regs-stamp bar.check-xml-regs-stamp

%.check-xml-regs-stamp: %.xml %.c
        stamp=$$(sed -ne 's|/. stamp: \(.*\) ./|\1|p' < $*.c); \
        if [ "$$(md5sum $*.xml)" = "$$stamp" ]; then \
           touch $@; \
        else \
           echo '.c file must be regenerated from .xml: $*.c' >&2; \
           exit 1; \
        fi


  reply	other threads:[~2007-10-05 17:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-05 15:34 Daniel Jacobowitz
2007-10-05 16:51 ` Jim Blandy
2007-10-05 16:54 ` Jim Blandy
2007-10-05 17:40   ` Daniel Jacobowitz
2007-10-05 17:52     ` Jim Blandy [this message]
2007-10-05 17:59       ` Daniel Jacobowitz
2007-10-15 19:26 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38x6hzbx4.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox