From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13161 invoked by alias); 28 Feb 2008 17:28:37 -0000 Received: (qmail 13147 invoked by uid 22791); 28 Feb 2008 17:28:36 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 28 Feb 2008 17:28:19 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m1SHSH6G016117 for ; Thu, 28 Feb 2008 12:28:17 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m1SHSHXO026011 for ; Thu, 28 Feb 2008 12:28:17 -0500 Received: from opsy.redhat.com (vpn-15-111.rdu.redhat.com [10.11.15.111]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m1SHSGUp002207; Thu, 28 Feb 2008 12:28:17 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 851665084A0; Thu, 28 Feb 2008 09:38:48 -0700 (MST) To: gdb-patches@sources.redhat.com Subject: Re: Patch: 'show args' -vs- '--args' References: <20080228164043.GD31695@caradoc.them.org> <20080228165420.GB1287@caradoc.them.org> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Thu, 28 Feb 2008 17:40:00 -0000 In-Reply-To: <20080228165420.GB1287@caradoc.them.org> (Daniel Jacobowitz's message of "Thu\, 28 Feb 2008 11\:54\:20 -0500") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00483.txt.bz2 >>>>> "Daniel" == Daniel Jacobowitz writes: Daniel> I'm fine with either the above [...] How about this? Tom ChangeLog: 2008-02-28 Tom Tromey * infcmd.c (notice_args_read): Print result of get_inferior_args. Index: infcmd.c =================================================================== RCS file: /cvs/src/src/gdb/infcmd.c,v retrieving revision 1.170 diff -u -r1.170 infcmd.c --- infcmd.c 28 Feb 2008 16:26:17 -0000 1.170 +++ infcmd.c 28 Feb 2008 17:26:48 -0000 @@ -273,9 +273,9 @@ notice_args_read (struct ui_file *file, int from_tty, struct cmd_list_element *c, const char *value) { - deprecated_show_value_hack (file, from_tty, c, value); - /* Might compute the value. */ - get_inferior_args (); + /* Note that we ignore the passed-in value in favor of computing it + directly. */ + deprecated_show_value_hack (file, from_tty, c, get_inferior_args ()); }