From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20159 invoked by alias); 9 Oct 2008 16:29:58 -0000 Received: (qmail 20151 invoked by uid 22791); 9 Oct 2008 16:29:57 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Oct 2008 16:29:15 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m99GTCex017742; Thu, 9 Oct 2008 12:29:12 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m99GTAYr006248; Thu, 9 Oct 2008 12:29:10 -0400 Received: from opsy.redhat.com (vpn-12-5.rdu.redhat.com [10.11.12.5]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m99GT9Qg000319; Thu, 9 Oct 2008 12:29:10 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B02C4888286; Thu, 9 Oct 2008 10:27:07 -0600 (MDT) To: "Pierre Muller" Cc: Subject: Re: Results of macscp.exp test on cygwin References: <011801c92a03$4b71afa0$e2550ee0$@u-strasbg.fr> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Thu, 09 Oct 2008 16:29:00 -0000 In-Reply-To: <011801c92a03$4b71afa0$e2550ee0$@u-strasbg.fr> (Pierre Muller's message of "Thu\, 9 Oct 2008 13\:36\:39 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00290.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> Shouldn't we force dwarf-2 debug format, or at least Pierre> skip the test if only stabs format is available? Seems like a decent idea to me. Pierre> FAIL: gdb.base/macscp.exp: c99 varargs expansion [...] Pierre> These failures are all due to the fact that stderr Pierre> is itself a macro in cygwin that is expanded into Pierre> "((__getreent())->_stderr)". These tests don't really require the use of fprintf or stderr -- any arbitrary identifier is fine. I'm testing this patch, which changes these names. Ok if it passes testing? Tom :ADDPATCH testsuite: 2008-10-09 Tom Tromey * gdb.base/macscp.exp: Use 'vafunc' and 'fixedarg' rather than 'fprintf' and 'stderr'. diff --git a/gdb/testsuite/gdb.base/macscp.exp b/gdb/testsuite/gdb.base/macscp.exp index 2a43a28..40546f9 100644 --- a/gdb/testsuite/gdb.base/macscp.exp +++ b/gdb/testsuite/gdb.base/macscp.exp @@ -566,44 +566,44 @@ gdb_test "macro expand SPLICE(robot, invasion)" \ # Varargs tests. -gdb_test "macro define va_c99(...) fprintf (stderr, __VA_ARGS__)" \ +gdb_test "macro define va_c99(...) varfunc (fixedarg, __VA_ARGS__)" \ "" \ "define first varargs helper" -gdb_test "macro define va2_c99(x, y, ...) fprintf (stderr, x, y, __VA_ARGS__)" \ +gdb_test "macro define va2_c99(x, y, ...) varfunc (fixedarg, x, y, __VA_ARGS__)" \ "" \ "define second varargs helper" -gdb_test "macro define va_gnu(args...) fprintf (stderr, args)" \ +gdb_test "macro define va_gnu(args...) varfunc (fixedarg, args)" \ "" \ "define third varargs helper" -gdb_test "macro define va2_gnu(args...) fprintf (stderr, ## args)" \ +gdb_test "macro define va2_gnu(args...) varfunc (fixedarg, ## args)" \ "" \ "define fourth varargs helper" gdb_test "macro expand va_c99(one, two, three)" \ - "expands to: *fprintf \\(stderr, *one, two, three\\)" \ + "expands to: *varfunc \\(fixedarg, *one, two, three\\)" \ "c99 varargs expansion" gdb_test "macro expand va_c99()" \ - "expands to: *fprintf \\(stderr, *\\)" \ + "expands to: *varfunc \\(fixedarg, *\\)" \ "c99 varargs expansion without an argument" gdb_test "macro expand va2_c99(one, two, three, four)" \ - "expands to: *fprintf \\(stderr, *one, two, three, four\\)" \ + "expands to: *varfunc \\(fixedarg, *one, two, three, four\\)" \ "c99 varargs expansion, multiple formal arguments" gdb_test "macro expand va_gnu(one, two, three, four)" \ - "expands to: *fprintf \\(stderr, *one, two, three, four\\)" \ + "expands to: *varfunc \\(fixedarg, *one, two, three, four\\)" \ "gnu varargs expansion" gdb_test "macro expand va_gnu()" \ - "expands to: *fprintf \\(stderr, *\\)" \ + "expands to: *varfunc \\(fixedarg, *\\)" \ "gnu varargs expansion without an argument" gdb_test "macro expand va2_gnu()" \ - "expands to: *fprintf \\(stderr\\)" \ + "expands to: *varfunc \\(fixedarg\\)" \ "gnu varargs expansion special splicing without an argument" # Stringification tests.