Re: PING: [PATCH] Fix a bug of addrmap

Daniel Jacobowitz
2008-11-25T18:00:46Z

On Tue, Nov 25, 2008 at 09:46:13AM -0800, Joel Brobecker wrote:
> The one comment that I have about this is that it's not automatically
> run when we run the testsuite. It would be really nice if they were.
>
> It's not the first time that we have unit-testing like this.
> For instance, check we have unit tests for observers, or xfullpath.
> Traditionally, they have been implemented inside testsuite/gdb.gdb.
> The current solution is not very elegant, in my opinion, as what we
> did was debugging GDB and call some functions inside GDB.
>
> How about, we add a testcase that "debugs" test-addrmap by simply
> running it to completion and checking its output (including the
> fact that it exited normally (meaning error code returned is zero)?

Could we move this test into a separate file, in gdb.gdb/, and arrange
for it to be linked with libgdb.a?

--
Daniel Jacobowitz
CodeSourcery