From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] [4/5] Types reference counting [varobj-validation]
Date: Thu, 16 Apr 2009 21:54:00 -0000 [thread overview]
Message-ID: <m38wm0clig.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090411102215.GE32624@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat\, 11 Apr 2009 12\:22\:15 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> As varobj_invalidate was unconditionally invalidating any local
Jan> varobjs more often calls to varobj_invalidate could become more
Jan> intrusive to the user so I also fixed varobj_invalidate to care
Jan> only about varobjs bound to the specific objfile.
I am not sure about this implementation.
It seems to me that a varobj expression can span multiple objfiles.
So, don't we have to use the same logic as Paul's recent "display"
change to determine whether a varobj expression is invalid?
Or am I missing something? I ask because it looks like we have
existing bugs here.
Tom
next prev parent reply other threads:[~2009-04-16 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 10:22 Jan Kratochvil
2009-04-11 11:28 ` Eli Zaretskii
2009-04-11 18:20 ` Jan Kratochvil
2009-04-16 21:54 ` Tom Tromey [this message]
2009-04-22 20:14 ` Jan Kratochvil
2009-05-25 8:18 ` obsolete: " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38wm0clig.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox