From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64770-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32146 invoked by alias); 24 Jun 2009 19:12:48 -0000
Received: (qmail 32135 invoked by uid 22791); 24 Jun 2009 19:12:47 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Jun 2009 19:12:37 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5OJCV6k027821; 	Wed, 24 Jun 2009 15:12:31 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5OJCUq1010333; 	Wed, 24 Jun 2009 15:12:30 -0400
Received: from opsy.redhat.com (vpn-12-198.rdu.redhat.com [10.11.12.198]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5OJCT0n025800; 	Wed, 24 Jun 2009 15:12:30 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 5B3AD3785E4; Wed, 24 Jun 2009 13:12:29 -0600 (MDT)
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org, ccoutant@google.com
Subject: Re: [RFA] comdat types preparation
References: <20090619234603.CCA7E843F5@localhost>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
Date: Wed, 24 Jun 2009 19:12:00 -0000
In-Reply-To: <20090619234603.CCA7E843F5@localhost> (Doug Evans's message of "Fri\, 19 Jun 2009 16\:46\:03 -0700 \(PDT\)")
Message-ID: <m38wjhigyq.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-06/txt/msg00657.txt.bz2

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> I tried to split my "comdat types" patch into two smaller chunks.
Doug> This one is the prelude to the real patch that adds the support.
Doug> This patch is just a code reorg.

Doug> Ok to check in?

This looks reasonable to me.

Doug> +  /* The bfd of this objfile.  */
Doug> +  bfd* abfd;

"bfd *".

Ok with that change, assuming it passed regression testing.

Tom