From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16250 invoked by alias); 29 Jul 2009 22:12:33 -0000 Received: (qmail 16240 invoked by uid 22791); 29 Jul 2009 22:12:32 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Jul 2009 22:12:24 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6TMCL7o018448; Wed, 29 Jul 2009 18:12:21 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n6TMCKBH018821; Wed, 29 Jul 2009 18:12:21 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n6TMCJV8032073; Wed, 29 Jul 2009 18:12:19 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 371555081C4; Wed, 29 Jul 2009 16:12:19 -0600 (MDT) To: Jan Kratochvil Cc: Eli Zaretskii , mark.kettenis@xs4all.nl, gdb-patches@sourceware.org Subject: Re: [patch] Fix warnings using gcc-4.5 HEAD References: <20090711082502.GA18801@host0.dyn.jankratochvil.net> <200907110836.n6B8a4Yn015392@brahms.sibelius.xs4all.nl> <20090711083928.GA30826@host0.dyn.jankratochvil.net> <837hyfy3fv.fsf@gnu.org> <20090711175937.GB18892@host0.dyn.jankratochvil.net> From: Tom Tromey Reply-To: tromey@redhat.com Date: Thu, 30 Jul 2009 00:28:00 -0000 In-Reply-To: <20090711175937.GB18892@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat\, 11 Jul 2009 19\:59\:37 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00724.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2009-07-11 Jan Kratochvil Jan> Fix gcc-4.5 HEAD warnings for enum ada_operator. Jan> * Makefile.in (HFILES_NO_SRCDIR): Add ada-operator.inc. Jan> * ada-lang.h (enum ada_operator): Move it to ... Jan> * ada-operator.inc: ... a new file. Jan> * expression.h (enum exp_opcode): Include ada-operator.inc. Jan> New element OP_UNUSED_LAST. I'd like Joel to comment on the Ada changes. They seem reasonable enough to me. I was unaware of enum ada_operator, yikes. At the very least, the comment above OP_EXTENDED0 needs to be updated. It mentions the extension enum approach, which now can't be used. Jan> Fix gcc-4.5 HEAD warnings for GDB_FORM_cached_string. Jan> * dwarf2read.c (GDB_FORM_cached_string) Jan> (dwarf_form_name ): Remove. Jan> (struct attribute ): Reduce the bit width. Jan> (struct attribute , DW_STRING_IS_CANONICAL): New. Jan> (read_attribute_value ) Jan> (read_attribute_value ): Initialize Jan> DW_STRING_IS_CANONICAL. Jan> (dwarf2_name, dump_die_shallow ) Jan> (dump_die_shallow ): Update the code using former Jan> GDB_FORM_cached_string. This part is ok. Jan> /* NOTE: Eventually, we expect to convert to an object-oriented Jan> formulation for expression operators that does away with the Jan> need for these extension operators, and indeed for this Jan> entire enumeration type. Therefore, consider the OP_EXTENDED Jan> definitions to be a temporary measure. */ This comment is nearly 6 years old :( Tom