From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11379 invoked by alias); 19 Oct 2009 17:47:47 -0000 Received: (qmail 11370 invoked by uid 22791); 19 Oct 2009 17:47:47 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Oct 2009 17:47:39 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9JHlYj0014258; Mon, 19 Oct 2009 13:47:35 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9JHlYdp027001; Mon, 19 Oct 2009 13:47:34 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n9JHlXvt029022; Mon, 19 Oct 2009 13:47:33 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 1119D37818E; Mon, 19 Oct 2009 11:47:33 -0600 (MDT) From: Tom Tromey To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org Subject: Re: [RFC][patch] Allow to disassemble line. References: <20091002004954.8966C76B2B@ppluzhnikov.mtv.corp.google.com> <8ac60eac0910080916i5a2eb49an5f21f3b5c7fb96ef@mail.gmail.com> <20091008162350.GA8625@caradoc.them.org> <8ac60eac0910080952p46f15693x6ed339473db0139d@mail.gmail.com> <8ac60eac0910161607k55fee22cs379c5b7635d7b6a@mail.gmail.com> Reply-To: tromey@redhat.com Date: Mon, 19 Oct 2009 17:47:00 -0000 In-Reply-To: <8ac60eac0910161607k55fee22cs379c5b7635d7b6a@mail.gmail.com> (Paul Pluzhnikov's message of "Fri, 16 Oct 2009 16:07:08 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00431.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: Paul> - ui_out_field_core_addr (uiout, "address", gdbarch, pc); Paul> + ui_out_field_core_addr (uiout, "pc_addr", gdbarch, pc); Changing a field name breaks MI clients. So, I don't think this part is ok. Paul> Index: ui-out.c [...] Paul> + if (strcmp (fldname, "pc_addr") == 0) Paul> + ui_out_text (uiout, pc_prefix (address)); I think magic field names and extra behavior in low-level ui-out functions is pretty ugly and also breaks an abstraction barrier. Why not directly call ui_out_text in dump_insns? Tom