From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23491 invoked by alias); 3 Mar 2010 16:26:11 -0000 Received: (qmail 23472 invoked by uid 22791); 3 Mar 2010 16:26:09 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Mar 2010 16:26:04 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o23GQ3qR015628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Mar 2010 11:26:03 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o23GQ28b002457; Wed, 3 Mar 2010 11:26:02 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o23GQ1JL026772; Wed, 3 Mar 2010 11:26:01 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 626E3379963; Wed, 3 Mar 2010 09:26:01 -0700 (MST) From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds References: <20100301103125.GB9730@calimero.vinschen.de> <20100301173054.GD5683@calimero.vinschen.de> <20100301193126.GA9416@caradoc.them.org> <20100303101630.GI17293@calimero.vinschen.de> <20100303104100.GJ17293@calimero.vinschen.de> <20100303105857.GM17293@calimero.vinschen.de> Reply-To: tromey@redhat.com Date: Wed, 03 Mar 2010 16:26:00 -0000 In-Reply-To: <20100303105857.GM17293@calimero.vinschen.de> (Corinna Vinschen's message of "Wed, 3 Mar 2010 11:58:57 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00099.txt.bz2 >>>>> "Corinna" == Corinna Vinschen writes: Corinna> Accidentally omitted from my former mail: Corinna> Since nl_langinfo is called only once here anyway, a simple Corinna> auto_host_charset_name = strdup (nl_langinfo (CODESET)); Corinna> would do. Thanks for noticing this. I've added this to my patch locally. Tom