From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19216 invoked by alias); 3 Mar 2010 22:00:35 -0000 Received: (qmail 19207 invoked by uid 22791); 3 Mar 2010 22:00:34 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Mar 2010 22:00:29 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o23M0RqL015483 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Mar 2010 17:00:27 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o23M0QmN016742; Wed, 3 Mar 2010 17:00:27 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o23M0G18026420; Wed, 3 Mar 2010 17:00:21 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id ADD09379963; Wed, 3 Mar 2010 15:00:15 -0700 (MST) From: Tom Tromey To: Sami Wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch] Add support for imported declaration and correct search order References: <4B86DA17.5040200@redhat.com> <20100225224145.GA21231@host0.dyn.jankratochvil.net> <4B8ED7C2.6030804@redhat.com> Reply-To: tromey@redhat.com Date: Wed, 03 Mar 2010 22:00:00 -0000 In-Reply-To: <4B8ED7C2.6030804@redhat.com> (Sami Wagiaalla's message of "Wed, 03 Mar 2010 16:42:26 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00134.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Sami> 2010-03-03 Sami Wagiaalla Sami> PR c++/7936: Getting close... Sami> +cp_add_using_directive (const char *dest, Sami> + const char *src, Sami> + const char *alias, Sami> + const char *declaration, Sami> struct obstack *obstack) [...] Sami> + if (declaration != NULL) Sami> + new->declaration = savestring (declaration, strlen (declaration)); obsavestring Does the duplicate exclusion logic here need to be updated to account for the new field? Sami> @@ -3448,23 +3448,32 @@ read_import_statement (struct die_info *die, struct dwarf2_cu *cu) Sami> + canonical_name = (char *) imported_name_prefix; I don't think you should need to cast away const in this function. There is some other way to make it work, like having a non-const temporary hold the result of alloca. Sami> + else Sami> + { Sami> + canonical_name = alloca (strlen (imported_name) + 1); Sami> + strcpy (canonical_name, imported_name); Sami> + } I think this is a pointless copy, just do canonical_name = imported_name. thanks, Tom