From: Tom Tromey <tromey@redhat.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] varobj.c c_describe_child
Date: Thu, 25 Mar 2010 18:29:00 -0000 [thread overview]
Message-ID: <m38w9gfe5f.fsf@fleche.redhat.com> (raw)
In-Reply-To: <ho8h62$4ic$1@dough.gmane.org> (Aleksandar Ristovski's message of "Mon, 22 Mar 2010 15:41:54 -0400")
>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:
Aleksandar> Note that with latest gdb from HEAD it doesn't crash, I
Aleksandar> believe due to recent changes in lazy allocating the values,
Aleksandar> but it still seems wrong to keep all these intermediate
Aleksandar> values generated by adjust_value_for_child_access' in
Aleksandar> 'all_values' list.
I think these values will automatically be freed the next time an MI
command is executed. The call chain is mi_cmd_execute ->
prepare_execute_command -> free_all_values.
Or is the idea to limit the transient amount of memory used?
I can't tell from the patch.
In that case, I think it would be more typical to use
value_mark and value_free_to_mark.
Tom
next prev parent reply other threads:[~2010-03-25 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 19:42 Aleksandar Ristovski
2010-03-25 18:29 ` Tom Tromey [this message]
2010-03-25 19:20 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38w9gfe5f.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox