From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: RFC: fix bug in pieced value with offset
Date: Thu, 13 May 2010 20:54:00 -0000 [thread overview]
Message-ID: <m38w7ntu36.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3hbmbviko.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu, 13 May 2010 11:04:55 -0600")
>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
Tom> I plan to check this in. I would appreciate comments, though; I think I
Tom> got the big-endian stuff right, but I am having trouble thinking about
Tom> it very clearly, and I also had trouble creating a test case that might
Tom> show the difficulties.
I also belatedly realized a second problem:
Tom> for (i = 0; i < c->n_pieces; i++)
Tom> {
I think this loop needs an additional condition to avoid overwriting the
destination buffer. I'm testing an updated patch; don't let this stop
you from commenting on the rest of it, though :-)
Tom
next prev parent reply other threads:[~2010-05-13 20:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 17:09 Tom Tromey
2010-05-13 20:54 ` Tom Tromey [this message]
2010-05-14 12:20 ` Jan Kratochvil
2010-05-14 17:54 ` Tom Tromey
2010-05-14 20:14 ` Jan Kratochvil
2010-05-14 20:02 ` Tom Tromey
2010-05-14 20:19 ` Jan Kratochvil
2010-05-14 21:27 ` Tom Tromey
2010-05-14 22:35 ` Jan Kratochvil
2010-05-21 19:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38w7ntu36.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox