From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73427-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21258 invoked by alias); 1 Jun 2010 20:00:10 -0000
Received: (qmail 21225 invoked by uid 22791); 1 Jun 2010 20:00:08 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 19:59:54 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o51JxruR013109	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 1 Jun 2010 15:59:53 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o51JxqvP012772;	Tue, 1 Jun 2010 15:59:52 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o51JxpKj020962;	Tue, 1 Jun 2010 15:59:51 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 157D73782DC; Tue,  1 Jun 2010 13:59:51 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org, sami wagiaalla <swagiaal@redhat.com>
Subject: Re: [patch] Remove redundant symbol naming from new_symbol
References: <4BFE83F0.2090908@redhat.com> <4C055DBD.7040300@redhat.com>
Reply-To: tromey@redhat.com
Date: Tue, 01 Jun 2010 20:00:00 -0000
In-Reply-To: <4C055DBD.7040300@redhat.com> (Keith Seitz's message of "Tue, 01	Jun 2010 12:21:33 -0700")
Message-ID: <m38w6y5xs8.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00020.txt.bz2

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

>> On 05/27/2010 07:38 AM, sami wagiaalla wrote:
>> This patch removes the redundant calls.

Thanks.

Keith> FWIW, I think this patch should be approved; the additional calls to
Keith> dwarf2_full_name do appear to be redundant, since SYMBOL_SET_NAMES is
Keith> called unconditionally for every symbol with DW_AT_name.

Thanks for looking at this.

This patch is ok.

Tom