From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76995-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1692 invoked by alias); 14 Dec 2010 16:42:42 -0000
Received: (qmail 1615 invoked by uid 22791); 14 Dec 2010 16:42:40 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 16:42:36 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBEGgY4o007343	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 14 Dec 2010 11:42:34 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oBEGgYuv013417;	Tue, 14 Dec 2010 11:42:34 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oBEGgXPS027318;	Tue, 14 Dec 2010 11:42:33 -0500
Received: by opsy.redhat.com (Postfix, from userid 500)	id 5C88C37848F; Tue, 14 Dec 2010 09:42:33 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Add an evaluation function hook to Python breakpoints.
References: <m38vztlr2r.fsf@redhat.com>
Date: Tue, 14 Dec 2010 16:42:00 -0000
In-Reply-To: <m38vztlr2r.fsf@redhat.com> (Phil Muldoon's message of "Mon, 13	Dec 2010 13:50:36 +0000")
Message-ID: <m38vzss3uu.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00240.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> +class.  The @code{gdb.Breakpoint} class can be sub-classed and, in
Phil> +particular, you may choose to implement the @code{evaluate} function.

I think this should say "method" and not "function".

Also I think the new method should be defined using @defop, like we do
for pretty-printer methods.  I suggest moving this paragraph down below
the @defmethod for __init__, but before the watchpoint types table, and
putting the @defop there as well.

Tom