From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: handle case arising from GCC PR 47510
Date: Thu, 03 Feb 2011 21:07:00 -0000 [thread overview]
Message-ID: <m38vxwesin.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110203085907.GA16851@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu, 3 Feb 2011 09:59:07 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> Then cp_lookup_nested_type crashes as TYPE_TAG_NAME (parent_type)
Jan> == NULL - which is correct for anonymous struct - but
Jan> cp_lookup_nested_type does not expect it.
[...]
After coming up with some more examples, it turns out that the DWARF
reading part of this patch is very misguided. In particular it would
fail if the typedef appeared before the anonymous struct (and GCC did
emit this when a namespace was used). And, a more complicated solution
(deferring this smashing until after all DIEs were processed) had a
problem of its own (we needed multi-level deferrals due to local types).
I've asked for a new attribute from GCC, instead, to make the problem
more tractable on the gdb side. We'll see what happens.
Meanwhile I will probably put in the valops.c change.
Tom
prev parent reply other threads:[~2011-02-03 21:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 20:21 Tom Tromey
2011-02-02 21:12 ` Jan Kratochvil
2011-02-02 21:47 ` Michael Snyder
2011-02-02 21:50 ` copyright in testcase .cc [Re: RFC: handle case arising from GCC PR 47510] Jan Kratochvil
2011-02-02 21:58 ` Tom Tromey
2011-02-02 22:04 ` RFC: handle case arising from GCC PR 47510 Tom Tromey
2011-02-03 8:59 ` Jan Kratochvil
2011-02-03 21:07 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38vxwesin.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox