From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6826 invoked by alias); 8 Mar 2011 19:50:16 -0000 Received: (qmail 6807 invoked by uid 22791); 8 Mar 2011 19:50:15 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 19:50:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p28Jnxkh025131 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Mar 2011 14:49:59 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p28JnwY9016225; Tue, 8 Mar 2011 14:49:58 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p28Jnv0c024278; Tue, 8 Mar 2011 14:49:58 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 90C2E3782A7; Tue, 8 Mar 2011 12:49:57 -0700 (MST) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Jan Kratochvil Subject: Re: RFC: lazily call save_current_space_and_thread References: <201103081715.49038.pedro@codesourcery.com> Date: Tue, 08 Mar 2011 19:54:00 -0000 In-Reply-To: (Tom Tromey's message of "Tue, 08 Mar 2011 10:20:43 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00566.txt.bz2 Pedro> I think the case at hand is while we're handling internal Pedro> events, before giving the prompt to the user. Is that so? Tom> Yes, that is what is happening. Tom> I will try to reword the comment to be more clear. What do you think of this? /* When processing internal events, there might not be a selected frame. If we naively call get_selected_frame here, then we can end up reading debuginfo for the current frame, but we don't generally need the debuginfo at this point. */ Tom