From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80933-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1151 invoked by alias); 10 May 2011 14:29:45 -0000
Received: (qmail 1140 invoked by uid 22791); 10 May 2011 14:29:44 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 May 2011 14:29:20 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4AET7GZ026076	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 10 May 2011 10:29:07 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p4AET6uC012167;	Tue, 10 May 2011 10:29:07 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4AET6Wh006110;	Tue, 10 May 2011 10:29:06 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id C6F9C3784CB; Tue, 10 May 2011 08:29:05 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: vanboxem.ruben@gmail.com
Cc: gdb-patches@sourceware.org,        mingw64 <mingw-w64-public@lists.sourceforge.net>
Subject: Re: [PATCH] 64-bit python support
References: <BANLkTi=2gphWs2p_5V+wTJMUAkjHDT79uQ__10646.2358417504$1305032253$gmane$org@mail.gmail.com>
Date: Tue, 10 May 2011 14:29:00 -0000
In-Reply-To: <BANLkTi=2gphWs2p_5V+wTJMUAkjHDT79uQ__10646.2358417504$1305032253$gmane$org@mail.gmail.com>	(Ruben Van Boxem's message of "Tue, 10 May 2011 14:57:09 +0200")
Message-ID: <m38vuesk7k.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00244.txt.bz2

>>>>> "Ruben" == Ruben Van Boxem <vanboxem.ruben@gmail.com> writes:

Ruben> Attached is a patch that tells gdb-python to use the Py_InitModule4_64
Ruben> function instead of Py_InitModule for 64-bit builds.

I think this should not be needed.  I think the bug must lie somewhere
else.  I say this because Python's modsupport.h should already do this
renaming:

#if SIZEOF_SIZE_T != SIZEOF_INT
/* On a 64-bit system, rename the Py_InitModule4 so that 2.4
   modules cannot get loaded into a 2.5 interpreter */
#define Py_InitModule4 Py_InitModule4_64
#endif

Tom