Re: [patch] PR python/12438

Phil Muldoon
2011-10-17T13:22:03Z

Kevin Pouget <kevin.pouget@gmail.com> writes:

> On Thu, Jun 30, 2011 at 11:37 AM, Phil Muldoon <pmuldoon@redhat.com> wrote:
>>
>> This patch addresses bug PR python/12438.  Mark - and other users - have
>> asked that maint set python print-stack is off by default.  This makes
>> sense to me, as while stack-traces are useful, they can impact
>> readability of GDB output.  Python developers can always turn it back on
>> again.
>
> Hello,
>
> I have a question regarding this patch, which was committed at the end of June,
> wouldn't GDB let the user know, one way or an other, that there was
> something wrong happened ?
>
> when you run a command, and see to "warning/error" message, you expect
> that everything went right, but that's not true when this flag is set,
> is it?
>
> I don't know if Python allows to do it, but i think it would be nice
> to see something like:
>
>> NameError: global name 'comp' is not define
>
> which is the last line of a python stacktrace

It was set that way so that "shipped" versions of GDB would not have
endless amounts of exceptions when pretty-printing. However I too have
begun to have second thoughts. I do multiple builds, and, inevitably, I
forget to turn error-printing back on, so that really throws me
sometimes. Fortunately, the should-print/should-not-print and the
resultant exception printing code is located centrally. I think your
idea is a good one, though I am trying to decide how useful that
information would be, and if something additional brief data should be
printed.

Cheers,

Phil